[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mv: do not produce diagnostics for xattr/selinux preserving

From: Ondřej Vašík
Subject: Re: [PATCH] mv: do not produce diagnostics for xattr/selinux preserving failures
Date: Fri, 24 Apr 2009 14:32:59 +0200


Ondřej Vašík wrote: 
> Jim Meyering píše v Pá 17. 04. 2009 v 13:54 +0200:
> > Ondřej Vašík wrote:
> > > as reported in rhbz #496142 by Eric Sandeen, mv produces a lot of
> > > unwanted messages when moving files to filesystem without xattr support.
> > > I guess mv selinux/xattr diagnostic error messages should be reduced as
> > > is done for cp -a, attached patch should do that.
> > ...
> > > +  mv: do not produce diagnostic errors for preserving xattr's to
> > > +  prevent message spam on file systems without xattr support.
> > 
> > Thanks for the patch, but mv's charter is stricter than that of cp -a.
> > I.e., people expect mv to preserve all attributes when the source
> > and destination are on the same file system, so IMHO, failure to
> > preserve any attribute (e.g., for an inter-device mv) requires
> > _some_ diagnosis.

> > However, when there are many files, and mv is failing to preserve some
> > attribute repeatedly, it would make sense to print only the first N
> > such diagnostics, and then for the N+1st, print one more saying that
> > there have been additional attribute-preservation failures, but mv will
> > not display any more.
> Changing proposed patch to not display diagnostics for ENODATA and
> ENOTSUP errno's - as is done for mv and SELinux contexts.

Actually I found that it was not exactly the same - as for
require-preserve=xattr error was hidden even for the failure. This
should be addressed by the first patch.

It reminds me another issue - due to reduce_diagnostic, if you use cp -a
--preserve=xattr,context , failure diagnostic is reduced, but the
command itself fails. Additionally for cp and --require-preserve=context
and ENODATA/ENOTSUP errors on destination filesystem cp just passes
without error - with no context preserved. All those things are
addressed by the second patch.

         Ondřej Vašík

Attachment: mvreducediagnostics.patch
Description: Text Data

Attachment: cp-nosilenceforrequiredattributes.patch
Description: Text Data

Attachment: signature.asc
Description: Toto je digitálně podepsaná část zprávy

reply via email to

[Prev in Thread] Current Thread [Next in Thread]