bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix check-AUTHORS skip logic.


From: Ralf Wildenhues
Subject: [PATCH] Fix check-AUTHORS skip logic.
Date: Sat, 25 Apr 2009 07:52:31 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

* src/Makefile.am (check-AUTHORS): When this test is skipped, be
sure to avoid all commands in the recipe, not just those passed
to the first shell.
---

Hello,

without this patch, I'm getting the following 'make check' failure:

  check-AUTHORS: skipping this check
  diff: authors-actual: No such file or directory
  make[2]: *** [check-AUTHORS] Error 2

Cheers,
Ralf

 src/Makefile.am |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index d8641d7..f7a26a7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -405,9 +405,9 @@ check-AUTHORS: $(all_programs)
            | perl -0 -pi -e 's/,\n/, /gm'              \
            | sed -n -e '/Written by /{ s//'"$$i"': /;' \
                  -e 's/,* and /, /; s/\.$$//; p; }';   \
-       done > $(au_actual)
-       @sed -n '/^[^ ][^ ]*:/p' $(top_srcdir)/AUTHORS > $(au_dotdot)
-       @diff $(au_actual) $(au_dotdot) && rm -f $(au_actual) $(au_dotdot)
+       done > $(au_actual) &&                          \
+       sed -n '/^[^ ][^ ]*:/p' $(top_srcdir)/AUTHORS > $(au_dotdot) && \
+       diff $(au_actual) $(au_dotdot) && rm -f $(au_actual) $(au_dotdot)
 
 # The following rule is not designed to be portable,
 # and relies on tools that not everyone has.
-- 
1.6.1.505.gba743





reply via email to

[Prev in Thread] Current Thread [Next in Thread]