Re: [PATCH] stdbuf work in progress

[Pádraig Brady]

Pádraig Brady wrote:
> Jim Meyering wrote:
>> I tried to build on Fedora 10 x86_64 and got this:
>>
>> /usr/bin/ld: ../lib/libcoreutils.a(quote.o): relocation R_X86_64_32 against 
>> `a local symbol' can not be used when making a shared object; recompile with 
>> -fPIC
>> ../lib/libcoreutils.a: could not read symbols: Bad value
>> collect2: ld returned 1 exit status
>> make[3]: *** [libstdbuf.so] Error 1
> 
> Hmm. There is no real need to link libcoreutils.a with libstdbuf.so.
> I had used fprintf(stderr,...) rather than error(..., quote())
> so I'll revert to that. That's better than compiling
> libcoreutils.a with -fPIC I think.
> 
> Though not necessary, I'd better also remove the reference to libcoreutils.a
> and document that in the Makefile.am so as we don't bump into this in future.

I've updated the patch at the above link to address this,
and also added a validation check in the shared lib itself.

http://www.pixelbeat.org/patches/stdbuf.diff

cheers,
Pádraig.