[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: remove one duplicity in copy.c caused by factorization
From: |
Pádraig Brady |
Subject: |
Re: [PATCH]: remove one duplicity in copy.c caused by factorization |
Date: |
Wed, 8 Jul 2009 21:48:01 +0100 |
User-agent: |
Thunderbird 2.0.0.6 (X11/20071008) |
Ondřej Vašík wrote:
> Hello,
> while making coreutils update for F-11, I spotted one duplicity in
> copy.c caused by
> http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=e0cf592f48b4e67dc31d0482ae4f4dbc820e883e
> factorization commit. Attached patch removes this duplicity.
Well spotted.
I changed the message slightly in the attached.
I'll hold off pushing it for the moment as
it doesn't cause a functional change and
I don't want to do anything to affect the
snapshot Jim's currently working on.
cheers,
Pádraig.
>From 6bc3d3bc86e29ca1350d032f09f0139d7970af80 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= <address@hidden>
Date: Wed, 8 Jul 2009 17:21:27 +0100
Subject: [PATCH] copy.c: remove a duplicate expression
* src/copy.c (copy_attr_error): remove a redundant expression
added in commit e0cf592f, 2009-04-27, "factor out test for errno ...".
---
src/copy.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/copy.c b/src/copy.c
index 511f705..4c8c432 100644
--- a/src/copy.c
+++ b/src/copy.c
@@ -146,7 +146,6 @@ copy_attr_error (struct error_context *ctx ATTRIBUTE_UNUSED,
va_list ap;
if (!errno_unsupported (errno))
- if (errno != ENOTSUP && errno != ENODATA)
{
/* use verror module to print error message */
va_start (ap, fmt);
--
1.6.2.5