[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Linus' sha1 is much faster!
From: |
Linus Torvalds |
Subject: |
Re: Linus' sha1 is much faster! |
Date: |
Sat, 15 Aug 2009 13:54:23 -0700 (PDT) |
User-agent: |
Alpine 2.01 (LFD 1184 2008-12-16) |
On Sat, 15 Aug 2009, Linus Torvalds wrote:
>
> That said, I don't know if the MPL is ok for X11. I've not looked at
> compatibility issues with MPL. For git, we could just ignore the MPL,
> since the GPLv2 was acceptable regardless of it.
If MPL isn't ok for X11, then we'd need to make sure that even the
silliest Mozilla crud has been rewritten. There really isn't much, but
hey, the _history_ is based on the mozilla code, and who knows - the
'blk_SHA_CTX' struct has things like the fields in the same order as the
Mozilla equivalent, for all those historical reasons.
(Heh. Looking at that, I probably should move the 'size' field first,
since that would have different alignment rules, and the struct would be
more tightly packed that way, and initialize better).
Afaik, none of the actual code remains (the mozilla SHA1 thing did the
wrong thing for performance even for just the final bytes, and did those a
byte at a time etc, so I rewrote even the trivial SHA1_Final parts).
Of course, maybe the Mozilla people would be interested in taking my
faster version, and say that the new-BSD license is ok, and make everybody
happy. The only listed author for the Mozilla SHA1 is Paul Kocher. I added
him to the Cc.
Paul, for your information, we're talking about a faster rewritten "mostly
portable" SHA1 routines that you can find at
http://git.kernel.org/?p=git/git.git;a=tree;f=block-sha1;hb=pu
(follow the "blob" pointers to see sha1.c and sha1.h). I don't know if
you're active with Mozilla/Firefox or whether you even care, but you seem
to be the logical choice of person to ask.
Linus
Re: Linus' sha1 is much faster!, Giuseppe Scrivano, 2009/08/16
Re: Linus' sha1 is much faster!, Pádraig Brady, 2009/08/16