[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: dd and closed stderr
|
From: |
Pádraig Brady |
|
Subject: |
Re: dd and closed stderr |
|
Date: |
Fri, 28 Aug 2009 16:57:06 +0100 |
|
User-agent: |
Thunderbird 2.0.0.6 (X11/20071008) |
Eric Blake wrote:
> Subject: [PATCH 2/2] build: avoid unused variable warnings on cygwin
>
> -clone_file (int dest_fd, int src_fd)
> +clone_file (int dest_fd ATTRIBUTE_UNUSED, int src_fd ATTRIBUTE_UNUSED)
Minor nit. Would it be better to put "(void) dest_fd; (void) src_fd;"
in the else clause here as those parameters need to be used usually.
cheers,
Pádraig.