[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: areadlinkat

From: Jim Meyering
Subject: Re: areadlinkat
Date: Wed, 07 Oct 2009 21:10:40 +0200

Eric Blake wrote:
> Eric Blake <ebb9 <at> byu.net> writes:
>> The patch copies from areadlink.c, as well as link_follow earlier in
>> linkat.c, to create two new fd-relative helpers.  For now, I didn't see
>> any reason to expose them, but areadlinkat may someday be worth making
>> into a full-blown module.
> Further looking shows that:
> findutils' listfile.c currently uses a home-rolled get_link_name_at which
> blindly changes the working directory, and calls xalloc_die on allocation
> failure.  Perfect candidate for xreadlinkat, to be more efficient on platforms
> with native readlinkat.  And xreadlinkat implies areadlinkat.
> coreutils' copy.c currently uses areadlink_with_size for copying/moving
> symlinks across partitions, but since we want to rewrite this to use fts, we
> will need an *at variant.
> So, I've written three new modules: areadlinkat, areadlinkat-with-size, and
> xreadlinkat; mirroring the three existing modules areadlink, areadlink-with-
> size, xreadlink.
> Eric Blake (4):
>       areadlink, areadlink-with-size: add tests
>       areadlinkat: new module
>       xreadlinkat: new module
>       areadlinkat-with-size: new module

That sounds like fine work, but I haven't looked carefully yet.
At least two of those patches were mangled in
the mail (long lines were wrapped).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]