[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: system.h cleanups

From: Jim Meyering
Subject: Re: system.h cleanups
Date: Thu, 08 Oct 2009 17:30:39 +0200

Pádraig Brady wrote:

> Eric Blake wrote:
>>>From 69b7a7ab900a043d6330b400659fb69a1aedde8e Mon Sep 17 00:00:00 2001
>> From: Eric Blake <address@hidden>
>> Date: Thu, 8 Oct 2009 08:13:02 -0600
>> Subject: [PATCH 1/3] maint: move timeout exit statuses
>> * src/timeout.c (EXIT_TIMEDOUT, EXIT_CANCELED): Remove as
>> macros...
>> * src/system.h (EXIT_TIMEDOUT, EXIT_CANCELED): ...and provide as
>> enum values instead.
> I'm not against this but EXIT_TIMEDOUT is specific to timeout.

Good point.
I see little benefit to moving it out to system.h.

I'm all for the macro-to-enum conversion though.
How about just doing that and leaving them in timeout.c?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]