[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] sort: Add --threads option, which parallelizes internal sort
Re: [PATCH] sort: Add --threads option, which parallelizes internal sort.
Mon, 19 Oct 2009 07:31:51 +0200
Chen Guo wrote:
> Ah how ridiculously careless of me. >.<
> I've ran through the checklist you provided, minus the mallocs.
> When would it be not ok to exit upon malloc failure? I've ran through all of
> sort.c and it seems in all cases of memory allocation xmalloc or xnmalloc are
> used. Thanks!
It's inappropriate in library-style code, and sort.c is not that,
so using x*alloc is all you need to do.