bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] issue warnings for more missing optional libraries


From: Jim Meyering
Subject: Re: [PATCH] issue warnings for more missing optional libraries
Date: Mon, 19 Oct 2009 13:14:24 +0200

Pádraig Brady wrote:
> I was going to mention some optional packages for coreutils in README-prereq
>
>     libselinux-devel
>     libcap-devel
>     libattr-devel
>     gmp-devel
>     libacl-devel
>
> However these names are linux specific and probably even fedora specific,
> so what would be better I think is for configure to give appropriate warnings.
> Well there are warnings actually for libselinux and libcap which one can 
> easily miss
> due to the default configure verbosity, so I've changed the example in 
> README-hacking
> to read `./configure --quiet`
>
> I've also added similar warnings for missing libattr, gmp and libacl.
> The first 2 are contained in coreutils while acl.m4 is part of gnulib.
>
> The configure output with the patches is:
>
>     configure: WARNING: GNU coreutils will be built without ACL support.
>     configure: WARNING: libselinux was found but selinux/selinux.h is missing.
>     configure: WARNING: GNU coreutils will be compiled without SELinux 
> support.
>     configure: WARNING: GNU coreutils will be built without xattr support.
>     configure: WARNING: libcap library was not found or not usable.
>     configure: WARNING: GNU coreutils will be built without capability 
> support.
>     configure: WARNING: GNU coreutils will be built without GMP support.

Good idea.
The patch looks fine.
You're welcome to push that as-is, or ...

What do you think about suggesting with each how to install
the missing package, e.g.,

    You can install the required libgmp.* files
    via "yum install gmp-devel" on a fedora-based system,
    or "apt-get install gmp-devel" on a  debian-based system.

The easier we make it for people to discover which libraries are
required/recommended and to install them, the more often people will use them.

No big deal, though.

>>From 961a5bd196c861ba41a2954e93d653fd8ff22a02 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
> Date: Mon, 19 Oct 2009 11:12:40 +0100
> Subject: [PATCH] maint: issue warnings for more missing optional libraries
>
> * README-hacking: Suggest to use ./configure --quiet so that
> any warnings are easily noticed.
> * m4/gmp.m4 (cu_GMP): Warn if libgmp is not used.
> * m4/jm-macros.m4 (coreutils_MACROS): Normalize the libcap warning.
> * m4/xattr.m4 (gl_FUNC_XATTR): Warn if libattr not used.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]