[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] md5: accepts a new --threads option

From: Paolo Bonzini
Subject: Re: [PATCH] md5: accepts a new --threads option
Date: Thu, 22 Oct 2009 16:54:33 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

On 10/22/2009 01:09 PM, Pádraig Brady wrote:
Jim Meyering wrote:
Pádraig Brady wrote:

p.s. I'll look at bypassing stdio on input to see
if I can get at least the 2% back

IMHO, even if it did, it would not be worth it.

Right, a quick test here shows only a 0.8% gain from
bypassing stdio. However I also noticed that the
digest routines in gnulib do fread(4096).
Bumping that up to 32KiB gives a 3% boost.
That would be increased even more if more efficient
checksumming routines are used (which is on the horizon).
Note the coreutils min was bumped to 32KiB recently:

Does anyone have any objections to increasing
the stack requirement by 28672 bytes?

I do. It's common for threads to not have a >32 kb thread. What I don't object to, is mallocing the buffer. :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]