[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: enable -Werror for lib/ in coreutils
From: |
Jim Meyering |
Subject: |
Re: enable -Werror for lib/ in coreutils |
Date: |
Thu, 29 Oct 2009 09:25:56 +0100 |
Pádraig Brady wrote:
> Jim Meyering wrote:
>> Subject: [PATCH 2/2] build (--enable-gcc-warnings): enable gcc's -Werror
>> also in lib/
>>
>> * configure.ac (GNULIB_WARN_CFLAGS): Define.
>> * lib/Makefile.am (AM_CFLAGS): Use $(GNULIB_WARN_CFLAGS)
>> rather than $(WARN_CFLAGS) and add $(WERROR_CFLAGS).
>> * gl/lib/isnan.c.diff: New file.
>> * gl/lib/regcomp.c.diff: New file.
>> * gl/lib/regex_internal.c.diff: New file.
>> * gl/lib/regexec.c.diff: New file.
>> * gl/lib/strftime.c.diff: New file.
>> * gl/lib/unicodeio.c.diff: New file.
>
> Are you maintaining diffs or patching gnulib directly.
> Seems like it might be more trouble than it's worth to maintain diffs.
> If patching directly then modules/regex would need to depend on verify.
>
> Also is verify.h needed here?
Thanks. It was not technically needed,
but it was desired, for consistency. I've added it.
>> diff --git a/gl/lib/regcomp.c.diff b/gl/lib/regcomp.c.diff
>> +
>> ++#include "intprops.h"
>
> ++#include "verify.h" ?
- enable -Werror for lib/ in coreutils, Jim Meyering, 2009/10/27
- Re: enable -Werror for lib/ in coreutils, Eric Blake, 2009/10/27
- Re: enable -Werror for lib/ in coreutils, Pádraig Brady, 2009/10/27
- Re: enable -Werror for lib/ in coreutils,
Jim Meyering <=
- Re: enable -Werror for lib/ in coreutils, Bruno Haible, 2009/10/27
- Re: enable -Werror for lib/ in coreutils, Jim Meyering, 2009/10/28
- Re: enable -Werror for lib/ in coreutils, Paolo Bonzini, 2009/10/28
- Re: enable -Werror for lib/ in coreutils, Jim Meyering, 2009/10/29
- Re: enable -Werror for lib/ in coreutils, Paolo Bonzini, 2009/10/29
- Re: enable -Werror for lib/ in coreutils, Jim Meyering, 2009/10/29
- Re: enable -Werror for lib/ in coreutils, Paolo Bonzini, 2009/10/29
- Re: enable -Werror for lib/ in coreutils, Jim Meyering, 2009/10/29
- Re: enable -Werror for lib/ in coreutils, Jim Meyering, 2009/10/29