[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

sort link failure due to sleep

From: Eric Blake
Subject: sort link failure due to sleep
Date: Mon, 23 Nov 2009 18:06:01 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

In post-8.1 git, coreutils now fails to link on cygwin 1.5:

  CCLD   sort.exe
sort.o: In function `pipe_fork':
/home/eblake/coreutils-tmp/src/sort.c:898: undefined reference to `_rpl_sleep'
collect2: ld returned 1 exit status

this was caused by the gnulib patch:

  sleep: work around cygwin bug

and the fact that the gnulib testsuite relies on sleep, but coreutils itself 
was not using the module.  Thus, sleep.o (and rpl_sleep) was only being 
compiled for the gnulib-tests directory.  This patch fixes it; okay to apply?  
Or should I go with an alternative patch of making sort.c use xnanosleep 
instead of sleep?  (For that matter, if we went with xnanosleep, we could make 
sort's child wait loop start with something smaller, like 0.25 seconds, instead 
of a minimum granularity of 1 second.)

From: Eric Blake <address@hidden>
Date: Mon, 23 Nov 2009 11:01:10 -0700
Subject: [PATCH] build: fix link failure on cygwin

gnulib now replaces sleep on cygwin, so we need to use the module.

* bootstrap.conf (gnulib_modules): Add sleep.
 bootstrap.conf |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 1828318..efe4f2d 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -195,6 +195,7 @@ gnulib_modules="
+  sleep

reply via email to

[Prev in Thread] Current Thread [Next in Thread]