|
From: | Pádraig Brady |
Subject: | Re: Incorrect use of USE_XATTR in coreutils-8.4 |
Date: | Mon, 25 Jan 2010 12:21:42 +0000 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 |
On 25/01/10 11:51, Jim Meyering wrote:
Pádraig Brady wrote:Subject: [PATCH] syntax-check: detect incorrect boolean macro values in config.h * modules/maintainer-makefile (configure.ac): Parameterize the location of config.h. The logic is from Eric Blake and the location indicated by Jim Meyering. Note CONFIG_HEADER is a forbidden variable name. * top/maint.mk (sc_Wundef_boolean): New rule.That patch looks fine. What does "forbidden variable name" mean? Maybe say that this has the effect of exporting CONFIG_HEADER (via an AC_SUBST-like mechanism) so that Makefile.am files may use $(CONFIG_HEADER) ?
Amended patch with this attached: * modules/maintainer-makefile (configure.ac): Parameterize the location of config.h which will be available to make files as $(CONFIG_INCLUDE). The logic is from Eric Blake and the location indicated by Jim Meyering. Note the more natural CONFIG_HEADER name is prohibited by automake for backwards compatibility reasons. * top/maint.mk (sc_Wundef_boolean): New rule. cheers, Pádraig.
config-bool-macro.diff
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |