[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug #26512 (C_NORM unused)
From: |
Moritz Orbach |
Subject: |
bug #26512 (C_NORM unused) |
Date: |
Mon, 15 Feb 2010 21:05:58 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hello all,
attached is a patch for bug #26512
http://savannah.gnu.org/bugs/index.php?26512
Is it correct? make distcheck still passes all tests. There's a
seemingly useless C_RESET at every end of line, just before the next
color sequence at the start of the next line -- but that's the same
behaviour as "ls -x" before the patch, so maybe it is needed?
Could you please incorporate this into the next release?
The change in behaviour was introduced with the following commit. C_NORM was
unused since then.
commit 483297d5ddaea930d61da1da9c3f052cbd3c3810
Author: Ed Avis <address@hidden>
Date: Tue Feb 12 12:22:35 2008 +0100
ls --color no longer outputs unnecessary escape sequences
In --color mode, plain files do not get any color, not even white.
When no highlighting is required, ls outputs no escape sequence at all.
* src/ls.c (print_with_color):
(used_color): New global.
(indicator_no) [C_RESET]: New enum value.
(indicator_name) ["rs"]: Corresponding new string.
(color_indicator): Make the 'normal' and 'file' markers be NULL.
Use "rs" (C_RESET) to reset to ordinary colors.
(process_signals): Restore default colors only if necessary.
(main): Don't call prep_non_filename_text here.
(print_name_with_quoting): Call it here, instead.
> (prep_non_filename_text): Use C_RESET, not C_NORM.
(print_color_indicator): Return bool, not void.
Print nothing, when possible.
(put_indicator): Call prep_non_filename_text the first time.
* tests/misc/ls-misc: Test for above.
* tests/ls/color-dtype-dir: Adapt: no escapes around regular file name.
* TODO: Remove item.
* NEWS: Mention this.
Moritz
ls-c_norm.patch
Description: Text document
- bug #26512 (C_NORM unused),
Moritz Orbach <=