[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug#569020: coreutils: failure of install-C test on GNU/kFreeBSD

From: Pádraig Brady
Subject: Re: Bug#569020: coreutils: failure of install-C test on GNU/kFreeBSD
Date: Tue, 16 Feb 2010 01:05:15 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100111 Thunderbird/3.0.1

On 11/02/10 11:00, Pádraig Brady wrote:
On 11/02/10 10:29, Pádraig Brady wrote:
On 11/02/10 02:14, Michael Stone wrote:

FAIL: tail-2/inotify-hash-abuse2 (exit: 1)

tail: `f' has become inaccessible: No such file or directory
./tail-2/inotify-hash-abuse2: line 34: kill: (13733) - No such process
./tail-2/inotify-hash-abuse2: line 40: kill: (13733) - No such process

As far as I read the test, there will always be a race where f could be
temporarily unavailable between the mv and the touch.
I forget what it's supposed to be testing for, but to close that race, I

touch g
mv g f

would be better, no?

That's what we're explicitly trying to trigger.
`tail` should not exit in this case as -F is specified (--retry)

Perhaps if the box is heavily loaded it can't complete each
iteration of the loop within an average of 0.05s (in which
case the timeout would kick in), though I'd be surprised if your system
could only iterate < 20 times a second.

In any case, since the timeout is just here to ensure no tail's
are left running if the test is canceled, it's probably better
to explicitly clean up as in this patch. Could you try and reproduce
with this?

--- a/tests/tail-2/inotify-hash-abuse2
+++ b/tests/tail-2/inotify-hash-abuse2
@@ -28,7 +28,8 @@ touch f || framework_failure

debug='---disable-inotify -s .001'
-timeout 10 tail $debug -F f & pid=$!
+tail $debug -F f & pid=$!
+cleanup_() { kill $pid; }

for i in $(seq 200); do
kill -0 $pid || break;

I've pushed the above without waiting for feedback
as even if it has nothing to do with the failure,
it's more robust I think.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]