Re: [PATCH] maint: mark makefile "dist-hook" target as PHONY

[Jim Meyering]

Ralf Wildenhues wrote:
> * Jim Meyering wrote on Thu, Mar 18, 2010 at 08:33:01AM CET:
>> From: Jim Meyering <address@hidden>
>> Date: Thu, 18 Mar 2010 08:32:26 +0100
>> Subject: [PATCH] maint: mark makefile "dist-hook" target as PHONY
>
>> * src/Makefile.am (dist-hook): Mark target as PHONY.
>
> dist-hook is an Automake API.  Automake should mark it phony as soon
> as you define it, just as it does with other -hook or -local targets.
> Is that not working for you?

Hi Ralf,

I even checked for that, but did not use enough context.
Thanks.  Here's your fix.  Ok?


>From cab29edcf1f4f124d92a61e17623d6613487dbe7 Mon Sep 17 00:00:00 2001
From: Ralf Wildenhues <address@hidden>
Date: Thu, 18 Mar 2010 21:07:41 +0100
Subject: [PATCH] revert "maint: mark makefile "dist-hook" target as PHONY"

* src/Makefile.am (dist-hook): Do not mark this target
as PHONY, explicitly.  Automake does it for us.
---
 src/Makefile.am |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 5af6e85..ecb42a8 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -642,7 +642,6 @@ all_programs.list:
 # in order to generate all man pages, even those for which we don't
 # install a binary, require that all programs be built at distribution time.
 dist-hook: $(all_programs)
-.PHONY: dist-hook

 # Ensure that all programs are built so we can for example
 # subsequently syntax check all man pages.
--
1.7.0.2.455.g91132