[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7574: [PATCH]: echo, printf, stat: Allow only up to 8 bit octal inpu
From: |
Ondrej Vasik |
Subject: |
bug#7574: [PATCH]: echo, printf, stat: Allow only up to 8 bit octal input for backslash-escaped chars |
Date: |
Tue, 07 Dec 2010 09:41:59 +0100 |
Paul Eggert wrote:
> As a minor point, both uses like this:
>
> '4' <= *p && *p <= '7'
>
> can be replaced with something like this:
>
> '4' <= *p
>
...
>
> The replacements are not only shorter, but easier
> to understand, because otherwise the reader is left
> wondering why that unnecessary comparison to '7'
> (or '0') is in there.
Yep, you are right - as the octal value of *p/*b is checked later, this
shorter way is better readable and shorter.
Added the NEWS entry in addition to address Eric's email.
Greetings,
Ondrej Vasik
escaped-ninebit-octal-char.patch
Description: Text Data
- bug#7574: [PATCH]: echo, printf, stat: Allow only up to 8 bit octal input for backslash-escaped chars, Ondrej Vasik, 2010/12/06
- bug#7574: [PATCH]: echo, printf, stat: Allow only up to 8 bit octal input for backslash-escaped chars, Eric Blake, 2010/12/06
- bug#7574: [PATCH]: echo, printf, stat: Allow only up to 8 bit octal input for backslash-escaped chars, Paul Eggert, 2010/12/06
- bug#7574: [PATCH]: echo, printf, stat: Allow only up to 8 bit octal input for backslash-escaped chars,
Ondrej Vasik <=