bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16532: Test Fail: "tests/chown/separator"


From: Pádraig Brady
Subject: bug#16532: Test Fail: "tests/chown/separator"
Date: Fri, 24 Jan 2014 17:50:26 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 01/24/2014 04:58 PM, Assaf Gordon wrote:
> On 01/24/2014 07:46 AM, Bernhard Voelker wrote:
>>>> On 01/24/2014 04:09 AM, Pádraig Brady wrote:
>>>>> Oh right, grep ^$id_gn: it is so.
>>
>> BTW: I'd change the skip_ message to reflect the above mentioned
>> corner case where getent is not available, something like:
>>
>> -  skip_ "multiple IDs for group '$id_gn': $(getent group "$id_gn")"
>> +  skip_ "group '$id_gn' not biunique: $(getent group | grep "^$id_gn:")"
>>
> 
> Attached is an updated version, using grep and the suggested error message.
> On addition is a "tr '\n' ','" - because "skip" only shows the first line of 
> the message, and so multiple groups and not displayed.

If you remove the "" from "$()" the '\n' would be changed to spaces
Your changing to ',' is neater though.
Note to avoid a trailing ',' one can use ... | paste -s -d,

Anyway pushed.

thanks!
Pádraig.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]