bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16329: Acknowledgement (`head --lines=-0' prints nothing if no newli


From: Pádraig Brady
Subject: bug#16329: Acknowledgement (`head --lines=-0' prints nothing if no newline at the EOF)
Date: Wed, 29 Jan 2014 11:55:53 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 01/03/2014 08:40 PM, Алексей Шилин wrote:
> Looks like I was overly cautious about decrementing an unsigned...
> 
> size_t n = bytes_read;
> while (n)
>   {
>     if (all_lines)
>       n -= n ? 1 : 0;        // ...here.
>     else
> 
> As it is under `while (n)' statement, n is always true here, and thus the 
> ternary operator, though makes no
> harm, is needless, and the whole line can be replaced with just `n--;'. Sorry 
> for that.
> 
> The fixed version of the original patch is attached.
> 

I've updated the patch to also handle the pipe case,
and I added a test. Will push soon.

thanks,
Pádraig.

Attachment: head--lines-0.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]