bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16940: [PATCH] tests: Do not access /dev/tty if it does not exist


From: Bernhard Voelker
Subject: bug#16940: [PATCH] tests: Do not access /dev/tty if it does not exist
Date: Wed, 05 Mar 2014 10:17:06 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 03/05/2014 05:20 AM, Pádraig Brady wrote:
   if test -w /dev/full && test -c /dev/full &&
      test -w /dev/tty && test -c /dev/tty; then

This looks right.
However, I'm wondering why the 'test -t 1' right after
the exec redirection didn't already catch this:

  if test -w /dev/full && test -c /dev/full; then
  (
    exec >/dev/tty
    test -t 1 || exit 0
    nohup echo hi 2> /dev/full
    test $? = 125 || fail=1
    test -f nohup.out || fail=1
    test -s nohup.out && fail=1
    rm -f nohup.out
    exit $fail
  ) || fail=1
  fi

Does someone have a test log file with the failure?

Have a nice day,
Berny





reply via email to

[Prev in Thread] Current Thread [Next in Thread]