[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17035: [PATCH] chmod -c -R produces errors with special permissions
From: |
Pádraig Brady |
Subject: |
bug#17035: [PATCH] chmod -c -R produces errors with special permissions |
Date: |
Wed, 19 Mar 2014 02:38:54 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 03/18/2014 11:41 PM, Pádraig Brady wrote:
> On 03/18/2014 10:18 PM, Bernhard Voelker wrote:
>> On 03/18/2014 07:45 PM, Pádraig Brady wrote:
>>> The fix looks good. It seems this bug was introduced
>>> with the change to FTS in 5.1.0 (released Dec 2003)
>>
>> Wasn't it commit v5.2.1-690-gbc580f6?
>
> I think that restricted the issue to if (new_mode & (S_ISUID | S_ISGID |
> S_ISVTX))
> but the stat on the relative name was there previously?
But if that was the case then previous to v5.2.1 release
would have gotten the diagnostic without special mode bits,
which is unlikely as the issue would then very likely have been noticed.
So I dug a little further and the issue seems to be with where fts
was improved to not change directory when traversing in coreutils 6.0 in:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=c1994c16
Change is now pushed:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=09eda9ed
thanks,
Pádraig.