bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21757: md5sum: Accept different line endings in .md5 files


From: Bernhard Voelker
Subject: bug#21757: md5sum: Accept different line endings in .md5 files
Date: Mon, 26 Oct 2015 08:11:25 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 10/26/2015 02:51 AM, Pádraig Brady wrote:
> From 5e3d017e7bc66cf6f666160f774944c2ff52d1ae Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?P=C3=A1draig=20Brady?= <address@hidden>
> Date: Mon, 26 Oct 2015 01:26:04 +0000
> Subject: [PATCH] md5sum: quote all printed file names
> 
> This is especially significant when using --check
> with files generated on a windows system, where the \r
> characters produce corrupted and confusing error messages.
> This also ensures status messages are output on a single line.
> 
> * src/md5sum.c: Use quote() for printed file names.
> * tests/misc/md5sum.pl: Adjust accordingly.
> * NEWS: Mention the change in behavior.
> Fixes http://bugs.gnu.org/21757

tests/misc/sha1sum.pl now fails; you forgot to adjust the ERR
messages in there.

Otherwise, the patch looks good to me.
Thanks.

BTW: I was quite surprised to see that the other utilities -
sha{224,256,384,512}sum - don't have a single negative test.
I mean, there should be at least one case for each of these
utilities to check whether an invalid checksum leads to an
error message and an exit status != 0.

Have a nice day,
Berny





reply via email to

[Prev in Thread] Current Thread [Next in Thread]