[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29167: Acknowledgement (tests/ls/readdir-mountpoint-inode.sh is unst
|
From: |
Pádraig Brady |
|
Subject: |
bug#29167: Acknowledgement (tests/ls/readdir-mountpoint-inode.sh is unstable and should require root privileges) |
|
Date: |
Mon, 6 Nov 2017 21:37:25 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 06/11/17 04:06, Thomas Deutschmann wrote:
> Hi,
>
> here's a better fix (from Sebastian Kühn via
> https://bugs.gentoo.org/353164):
>
> diff --git a/tests/ls/readdir-mountpoint-inode.sh
> b/tests/ls/readdir-mountpoint-inode.sh
> index b4ca9e46e..5270df079 100755
> --- a/tests/ls/readdir-mountpoint-inode.sh
> +++ b/tests/ls/readdir-mountpoint-inode.sh
> @@ -55,7 +55,10 @@ inode_via_readdir()
> esac
> opts=$(ls_ignore_options "$base")
> parent_dir=$(dirname "$mount_point")
> - eval "ls -i $opts '$parent_dir'" | sed 's/ .*//'
> + ls_out=$(eval "ls -i $opts '$parent_dir'")
> + test $? -eq 0 || \
> + skip_ "'$parent_dir' is not readable for current user"
> + echo $ls_out | sed 's/ .*//'
> }
>
> while read dir; do
Pushed at:
https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.28-29-gaebefc2
Marking this as done.
thanks,
Pádraig