From 69f4b0db2af91b2b67608ae5205d54b7fff2a53c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Fri, 4 Jan 2019 09:29:13 -0800 Subject: [PATCH] tail: don't exit immediately with filters on AIX * src/tail.c: Avoid the check_output_available check on AIX. * tests/tail-2/pipe-f.sh: Fix the test which always passed due to only the exit code of sleep being checked. * NEWS: Mention the bug fix and rearrange alphabetically. Addresses http://bugs.gnu.org/33946 --- NEWS | 8 +++++--- src/tail.c | 5 +++++ tests/tail-2/pipe-f.sh | 5 ++++- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 4a57d22..6a9c0bc 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,9 @@ GNU coreutils NEWS -*- outline -*- ** Bug fixes + 'base64 a b' now correctly diagnoses 'b' as the extra operand, not 'a'. + [bug introduced in coreutils-5.3.0] + When B already exists, 'cp -il A B' no longer immediately fails after asking the user whether to proceed. [This bug was present in "the beginning".] @@ -21,9 +24,8 @@ GNU coreutils NEWS -*- outline -*- sync no longer fails for write-only file arguments. [bug introduced with argument support to sync in coreutils-8.24] - In 'base64 a b', and likewise for base32, the tool now correctly - diagnoses 'b' as the extra operand, not 'a'. - [bug introduced in coreutils-5.3.0] + 'tail -f file | filter' no longer exits immediately on AIX. + [bug introduced in coreutils-8.28] ** Changes in behavior diff --git a/src/tail.c b/src/tail.c index 0270cbe..85de88d 100644 --- a/src/tail.c +++ b/src/tail.c @@ -336,6 +336,11 @@ named file in a way that accommodates renaming, removal and creation.\n\ static void check_output_alive (void) { +#ifdef _AIX + /* TODO: AIX was seen to give a readable event immediately. */ + return; +#endif + if (! monitor_output) return; diff --git a/tests/tail-2/pipe-f.sh b/tests/tail-2/pipe-f.sh index 9231cac..4a5b444 100755 --- a/tests/tail-2/pipe-f.sh +++ b/tests/tail-2/pipe-f.sh @@ -37,7 +37,10 @@ compare exp out || fail=1 # This would wait indefinitely before v8.28 due to no EPIPE being # generated due to no data written after the first small amount -timeout 10 tail -f $mode $fastpoll out | sleep .1 || fail=1 +(returns_ 124 timeout 10 tail -n2 -f $mode $fastpoll out && touch timed_out) | + sed 2q > out2 +test -e timed_out && fail=1 +compare exp out2 || fail=1 # This would wait indefinitely before v8.28 (until first write) (returns_ 1 timeout 10 tail -f $mode $fastpoll /dev/null >&-) || fail=1 -- 2.9.3