[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33468: A bug with yes and --help
From: |
Assaf Gordon |
Subject: |
bug#33468: A bug with yes and --help |
Date: |
Fri, 15 Feb 2019 11:32:20 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hello Eric and all,
Thanks for the quick and detailed review.
I've amended all the issues you mentioned.
On 2019-02-13 8:20 p.m., Eric Blake wrote:
15 files changed, 46 insertions(+), 141 deletions(-)
Nice diffstat.
These are of course Bernhard's improvements,
I just did the testing (and some minor things).
diff --git a/NEWS b/NEWS
Is "argument" better than "option" here? Or, maybe:
now always process --help and --version options, regardless of any other
arguments present before any optinoal -- end-of-options marker.
I've used your phrasing, and also separated "nohup" from the rest
of the programs, as it does not accept --help/--version anywhere,
just as first arguments.
Attached updated patches, with tests.
comments welcomed,
- assaf
P.S.
There is at least one change in behavior, not sure if this is
bad enough to be a regression or doesn't really matter:
$ yes-OLD me -- --help | head -n1
me -- --help
$ yes-NEW me -- --help | head -n1
me --help
gnulib-0001-long-options-add-parse_gnu_standard_options_only.patch.gz
Description: application/gzip
0001-all-detect-help-and-version-more-consistently.patch.gz
Description: application/gzip
- bug#33468: A bug with yes and --help, Assaf Gordon, 2019/02/12
- bug#33468: A bug with yes and --help, Eric Blake, 2019/02/12
- bug#33468: A bug with yes and --help, Assaf Gordon, 2019/02/13
- bug#33468: A bug with yes and --help, Eric Blake, 2019/02/13
- bug#33468: A bug with yes and --help,
Assaf Gordon <=
- bug#33468: A bug with yes and --help, Eric Blake, 2019/02/15
- bug#33468: A bug with yes and --help, Assaf Gordon, 2019/02/18
- bug#33468: A bug with yes and --help, Bernhard Voelker, 2019/02/19
- bug#33468: A bug with yes and --help, Assaf Gordon, 2019/02/19
- bug#33468: A bug with yes and --help, Eric Blake, 2019/02/19
- bug#33468: A bug with yes and --help, Bernhard Voelker, 2019/02/21
- bug#33468: A bug with yes and --help, Bernhard Voelker, 2019/02/22
- bug#33468: A bug with yes and --help, Eric Blake, 2019/02/22
- bug#33468: A bug with yes and --help, Bernhard Voelker, 2019/02/22
- bug#33468: A bug with yes and --help, Bernhard Voelker, 2019/02/25