Re: [bug-cppi] [PATCH 1/3] build: use new gnulib module: non-recursive-gnulib-prefix-hack

[Jim Meyering]

Akim Demaille wrote:
> Le 19 sept. 2012 à 19:43, Jim Meyering a écrit :
>
>> [Cc'ing Akim, in case he wants to do this to bison.  If so,
>> with three projects using it, I'll move the module to gnulib. ]
>
> Yes, I do want that :)
>
>> @@ -142,8 +151,20 @@ sub prefix ($)
>>   # Unfortunately, as a result we sometimes have lib/lib.
>>   s{($prefix){2}}{$1}g;
>>
>> -  # $(srcdir) is actually $(top_srcdir)/lib.
>> -  s{\$\(srcdir\)}{\$(top_srcdir)/lib}g;
>> +  # lib_libcoreutils_a_SOURCES += \
>> +  #   imaxtostr.c \
>> +  #   inttostr.c \
>> +  #   offtostr.c \
>> +  #   uinttostr.c \
>> +  #   umaxtostr.c
>> +  # The above are not handled since they're on continued lines, so
>> +  # deal with them manually:
>> +  s{^  ((?:[ui]max|u?int|off)tostr\.c(:? \\)?)$}{  $prefix$1}gm;
>
> This is both very specific to coreutils, and maybe somewhat over
> specific (messing with the number of spaces would break everything).
> I don't care much about the first point, but maybe the second point
> should be addressed?

However, do note that it's not specific to coreutils.
The offending code is from gnulib's modules/inttostr.

    $ cat modules/inttostr
    Description:
    Convert integers to printable strings.

    Files:
    lib/anytostr.c
    lib/imaxtostr.c
    lib/inttostr.c
    lib/inttostr.h
    lib/offtostr.c
    lib/umaxtostr.c
    lib/uinttostr.c
    m4/inttostr.m4

    Depends-on:
    intprops
    stdint

    configure.ac:
    gl_INTTOSTR

    Makefile.am:
    lib_SOURCES += \
      imaxtostr.c \
      inttostr.c \
      offtostr.c \
      uinttostr.c \
      umaxtostr.c

    Include:
    "inttostr.h"

    License:
    LGPL

    Maintainer:
    Paul Eggert

There is currently only one other instance like this, and it's in a
test module (so not yet a concern for me -- or addressed):

    $ g grep -A9 'CES *+= *\\$' modules
    modules/havelib-tests:BUILT_SOURCES += \
    modules/havelib-tests-  havelib/Makefile.in \
    modules/havelib-tests-  havelib/rpathx/Makefile.in \
    modules/havelib-tests-  havelib/rpathx/aclocal.m4 \
    modules/havelib-tests-  havelib/rpathx/configure \
    modules/havelib-tests-  havelib/rpathy/Makefile.in \
    modules/havelib-tests-  havelib/rpathy/aclocal.m4 \
    modules/havelib-tests-  havelib/rpathy/configure \
    modules/havelib-tests-  havelib/rpathz/Makefile.in \
    modules/havelib-tests-  havelib/rpathz/aclocal.m4 \
    --
    modules/inttostr:lib_SOURCES += \
    modules/inttostr-  imaxtostr.c \
    modules/inttostr-  inttostr.c \
    modules/inttostr-  offtostr.c \
    modules/inttostr-  uinttostr.c \
    modules/inttostr-  umaxtostr.c
    modules/inttostr-
    modules/inttostr-Include:
    modules/inttostr-"inttostr.h"
    modules/inttostr-