RE: cvs patches & notes

[Gianni Mariani]

I proposed a patch to fix at this problem a few weeks ago.

I attached the message.  I now have a generic loginfo filter that places all
the info into a database.

Any better ideas ?

G

-----Original Message-----
From: bug-cvs-admin@gnu.org [mailto:bug-cvs-admin@gnu.org]On Behalf Of
Greg Klanderman
Sent: Friday, May 11, 2001 8:02 AM
To: Russ Tremain
Cc: greg@itasoftware.com; robs@chelsea.net; bug-cvs@gnu.org
Subject: Re: cvs patches & notes




>>>>> Russ Tremain <russt@ebay.sun.com> writes:

> Yep, it will break my code if you have a filename:
>
>       "foo,2.3 1.3,bar"
>
> So far, no one has been this perverted... :)
> Sounds like you are familiar with this problem.

just wanted to consider what level of perversion the hack would
withstand.  in this case i'd say the perversion is significant
enough that your solution is fine.

> In rethinking this, I think we should just add
> a new {u} specifier that would give us the file
> in url-encoded format, including commas.

sounds pretty reasonable.  i really only use the {t} specifier.

greg

_______________________________________________
Bug-cvs mailing list
Bug-cvs@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-cvs

--- Begin Message --- Subject: loginfo problems with file names with spaces or commas - patch to fix. Date: Sun, 25 Mar 2001 16:47:57 -0700

 

I'm trying to use a loginfo filter to create a database of change sets.  However, I am having problems coming up with a deterministic way of pasring the strings.

 

I have attached a patch which I submit to fix this - this patch adds 2 new loginfo format options. 'e' which is an escaped version of 's' and a 'T' format which is an escaped version of the branch tag.

 

So, do I go with the patch or is there an easier way to do this ?  I want to populate a database with all the information I get from loginfo.  I need to deal properly with file names containing anything the OS allows.  This will be used by an application that will allow the manipulation of change-sets, applying different change-sets to different branches etc.  However, I need to capture the information to begin with.

 

Thx

G

logformat.patch
Description: Binary data

--- End Message ---