bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "cvs server" accepts but ignored --allow-root


From: Tim Riker
Subject: Re: "cvs server" accepts but ignored --allow-root
Date: Fri, 22 Nov 2002 01:58:01 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020913 Debian/1.1-1

Not sure how to do a test for this. src/sanity.sh does one rsh test, but I don't think you can alter the command it runs on the other end? I believe it does "cvs server" and I need it to do "cvs server --allow-root ${CVSROOT_DIRNAME}" which should work. Anything else like "cvs server --allow-root ${CVSROOT_DIRNAME}/foo" should get an error when the client tries to choose a different path.

The current state is that "cvs server --allow-root ${CVSROOT_DIRNAME}/foo" _will_ allow setting the dirname to anything and will completely ignore the --allow-root without a warning or error message.

CVS_SERVER cannot contain arguments, correct? I suppose you could create a script like:

#!/bin/bash
exec cvs --allow-root /path/from/cvsroot_dirname $*

and then put the scriptname in CVS_SERVER?

Testing over rsh should work, but is kind of silly. I suppose an admin might provide a cvs wrapper as above and hide the real cvs binary. This really is used with ssh authorized_keys as explained in the original message.

Derek Robert Price wrote:> Tim Riker wrote:

patch attached to enable handling --allow-server for "cvs server" use. It's against 1.11.1p1 as I added it to server running the older release, but it's trivial, so applying to 1.11.2 would be easy.

Could you resubmit this patch with a test case and possibly documentation, as per the HACKING file in the top level of the source distribution?

Thanks,

Derek


--
Tim Riker - http://rikers.org/ - address@hidden
Lineo CTO - address@hidden - http://www.Lineo.com/
BZFlag maintainer - http://BZFlag.org/ - for fun!





reply via email to

[Prev in Thread] Current Thread [Next in Thread]