[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs has problems using LockDir when CVSROOT holds a symlink

From: Larry Jones
Subject: Re: cvs has problems using LockDir when CVSROOT holds a symlink
Date: Wed, 24 Sep 2003 12:55:31 -0400 (EDT)

Derek Robert Price writes [quoting Mark]:
> | It is also interesting that the RCS File: is 'more correct' in the
> |1.12.x version as it uses the symlink name rather than the canonical
> |name as a prefix in the path to the RCS,v filename.
> I'm not sure I agree that this is more correct, actually.

I'm quite sure that I disagree.  Anything visible to the user should use
the user's specified path.  A bit of syntactical cleaning up (like
removing extra slashes, /./, etc.) is OK, but not expanding symlinks.

> Actually, running sanity.sh with a -l argument appears to do this on
> 1.12.x.  I didn't recall leaving that hack there.

-l tests where the last component of the specified repository is a
symlink; it might also be useful to test the case where the symlink
appears at a higher level in the path.

> |I am all for centralizing code that need not be duplicated and
> |maintained in multiple filesubr.c versions.

I think we need to rethink the organization of filesubr.c -- there is a
lot of duplicated code that should be consolidated.

-Larry Jones

I think your train of thought is a runaway. -- Calvin's Mom

reply via email to

[Prev in Thread] Current Thread [Next in Thread]