Re: Patch for timezone handling in cvs log

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bart Robinson wrote:

>Here is the new patch, which uses the MT thing and does all
>conversion on the client side.


This is a step in the right direction, but I still have a few problems
with it:

   1. I don't like the -z option or the new TZ variables.  Why not use
      the standard interface for these functions and avoid confusing
      the users.  Leave timzone handling to the localtime() & mktime()
      functions.  They know what to look for already.
   2. You should be able to mix cvs_output() lines with
      cvs_output_tagged() lines.  The extensive conversion you
      performed on log.c was unecessary.  You should have only needed
      to convert the lines containing the dates.

If you make these changes (they should make the patch _much_ smaller),
and add some docs and maybe tests, I'm all for this patch.

Derek

- --
                *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAklyYLD1OTBfyMaQRAr2JAKDngUwzfdsUkgFTbNvFalGVCU9udgCfc3Dv
RZSk5tpCw1qDRchkcWBqPu8=
=A51q
-----END PGP SIGNATURE-----