bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: CVS Feature Branch - Windows Build Complete Warnings List 9-Sep-2004


From: Conrad T. Pino
Subject: RE: CVS Feature Branch - Windows Build Complete Warnings List 9-Sep-2004 09:30 PDT
Date: Thu, 9 Sep 2004 11:17:41 -0700

> From: Mark D. Baushke
> 
> Many thanks for the complete list of warnings.

You're welcome.

> I have removed the two unused variables in windows-NT/filesubr.c
> check_statbuf() and committed it for you.

I've verified these are gone.  Warning count dropped from 124 to 122.

> For the buffer.c warning, it might be useful to look and see if both
> count and tcount should be of type size_t at line 1465 of the file.

I tested "count" and "tcount" as type "size_t" and it cascades to another
warning for line 1515:

        if (count + 2 > pb->holdbufsize)

        H:\Conrad\Projects\cvs-1.12\src\buffer.c(1515) :
        warning C4018: '>' : signed/unsigned mismatch

and I'm reluctant to change definition of "pb" structure.

> I am less sure of the right way to quiet the rcs.c line 1573 warning.

I plead to greater ignorance.

> For warnings in lib or libdiff, we need to move upstream to the GNULIB
> project or the GNUDIFF project.

Derek had me do this before and I defer due to lack of time.

> I am not sure why nstrftime() is not getting a proper prototype used for
> it.

I plead to greater ignorance.

>       -- Mark

Conrad





reply via email to

[Prev in Thread] Current Thread [Next in Thread]