bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: windows-NT/mkconfig.pl & windows-NT/fix-msvc-mak.pl change


From: Derek Price
Subject: Re: windows-NT/mkconfig.pl & windows-NT/fix-msvc-mak.pl change
Date: Wed, 09 Mar 2005 14:46:30 -0500
User-agent: Mozilla Thunderbird 1.0 (Windows/20041206)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Conrad T. Pino wrote:

| Previously I wasn't aware of the existence of the intermediates on
| UNIX and of course they don't exist on Windows.  The commands I ran
|  on both Windows and UNIX are:
|
| cd ccvs perl windows-NT/fix-msvc-mak.pl cd windows-NT perl
| mkconfig.pl cd ..
|
| which in the case of "mkconfig" will generate:
|
| *** config.h.in, generated by mkconfig.pl:
|
| when run on either Windows and UNIX.
|
| I believe no patch is required.  I will correct my process now that
| I understand why the intermediates exist.


Yeah, but the intermediates are not necessary.  My patch calls, similarly,

~    perl mkconfig.pl

where a simple

~    ./mkconfig

used to be called.  Since there is no mkconfig file distributed or
checked in, my patch should sync what we are generating.  It also has
the advantage or simplifying by removing the unneeded intermediates.

Regardless, I think you have answered my question.  I will commit the
change and your previous build process should still suffice.

Have you thought about putting the `perl mkconfig.pl' and `perl
fix-msvc-mak.pl' calls into the MSVC build files (is that even
possible with fix-msvc-mak.pl?)?  It's always nice to encode our build
knowledge into automation when possible.

Regards,

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCL1KVLD1OTBfyMaQRAlmeAKCi0dQecn8Q9lfHndlIm2rt+fFDTACgnbtd
Az/X4epxDLpsm0h7OworT74=
=ZBf6
-----END PGP SIGNATURE-----






reply via email to

[Prev in Thread] Current Thread [Next in Thread]