[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: newtags
From: |
Derek Price |
Subject: |
Re: newtags |
Date: |
Tue, 19 Apr 2005 14:41:37 -0400 |
User-agent: |
Mozilla Thunderbird 1.0.2 (Windows/20050317) |
Oh, if you hadn't gathered, I committed your latest patch to the
`newtags' branch.
Cheers,
Derek
Derek Price wrote:
> Frank Hemer wrote:
>
> >I'd like to see my latest patch from 2005-04-08 18:03 beeing
> >commited to the newtags branch so I can continue working on it ...
>
>
>
> Sorry. I ran the tests and saw them pass the other day but I had been
> having a hard time finding the time to review your most recent
> changes. After a quick scan of your latest work, it looks to me like
> your changes are headed in the right direction. Some of it is fairly
> obviously simplification. I am still wondering whether there is a way
> to avoid handling magic numbers in so many locations - like maybe it
> should have been abstracted out by this portion of the code, but I
> haven't time for a full evaluation.
>
> Keep up the good work,
>
> Derek
_______________________________________________
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs
- newtags, Frank Hemer, 2005/04/19
- Re: newtags, Derek Price, 2005/04/19
- Re: newtags,
Derek Price <=