Re: Replace history's "<remote>" with client's IP

[Todd Denniston]

"Mark D. Baushke" wrote:
> 
> 
<SNIP>
> Well, I did something like this once for a test version of cvs. 

Mark, 
I know this is a quick test version, but I think I spotted a small problem
you may want to fix, in case you ever get around to getting it in the
mainline.

I believe

if (CurDir == NULL)
     CurDir = xstrdup ("<remote>");

should go after the #endif, so that you get the same behavior with the new
version as it would have before if SERVER_SUPPORT is undefined.

<SNIP>
> Index: main.c
> ===================================================================
> RCS file: /cvsroot/cvs/ccvs/src/main.c,v
> retrieving revision 1.172.4.16
> diff -u -p -u -p -r1.172.4.16 main.c
> --- main.c      2 Sep 2005 19:37:34 -0000       1.172.4.16
> +++ main.c      18 Oct 2005 19:08:51 -0000
<SNIP>
> @@ -716,7 +720,62 @@ distribution kit for a complete list of
>            it is worth the trouble.  */
> 
>         if (server_active)
> -           CurDir = xstrdup ("<remote>");
> +       {
> +#ifdef SERVER_SUPPORT
<SNIP>
> +           if (CurDir == NULL)
> +               CurDir = xstrdup ("<remote>");
> +#endif
> +       }
>         else
>         {
>             CurDir = xgetwd ();

-- 
Todd Denniston
Crane Division, Naval Surface Warfare Center (NSWC Crane) 
Harnessing the Power of Technology for the Warfighter