[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #17560] merge code in rcs.c is O(n^2)

From: Mark D. Baushke
Subject: [bug #17560] merge code in rcs.c is O(n^2)
Date: Tue, 5 Sep 2006 21:00:38 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc3 Firefox/1.0.7

Follow-up Comment #10, bug #17560 (project cvs):

I have made a few changes in the code from the
rcs.diff.3 patch:

 + Avoid C99/C++ "//" style comments.
   Use C89 "/* ... */" style comments.

 + Use white space to separate operators.

 + Put curly braces on their own lines.

 + Use xnmalloc (qty, size) instead of
   xnrealloc (NULL, qty, size)

 + Do not mix 'int' and and 'unsigned long' in comparisons.

It appears that the linevector_delete function is
no longer used. Should it be deleted?

I have started a 'make check on this revised patch.
If all goes well, I'll hope to commit tomorrow.
What attribution do you wish for the patch?
Maybe <address@hidden> would be okay?

Additional Item Attachment:

File name: rcs.c.patch                    Size:5 KB
Revised patch that conforms better to the CVS standards.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]