bug-findutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Findutils-patches] [PATCH] -delete requires -depth


From: Eric Blake
Subject: Re: [Findutils-patches] [PATCH] -delete requires -depth
Date: Thu, 23 Aug 2007 06:59:37 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to James Youngman on 8/23/2007 4:11 AM:
> I am proposing to make this change in findutils-4.3.9.    Any objections?

Bruno raised the objection on savannah that this approach is not
backwards-compatible (ie. scripts that used just -delete will now fail to
do anything).  However, I tend to agree with the idea that if we are
changing the behavior of -delete, an explicit error that explains what is
missing is important.  Bruno also had the idea of letting -delete operate
without -depth, by letting -delete swap the traversal of that subtree to
depth-first while the rest of the traversal is breadth-first prior to
encountering the -delete action.  I'm not sure that is possible, since my
understanding of fts() is that the traversal pattern is picked up front.

In other words, let's think this over a bit more before checking anything in.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGzYS584KuGfSFAYARAtPKAJ41qBFR2M04WXyMr66ffPtvwBgOfACfVuYc
rnm6HKJNFY6aXUeTWwfJrvQ=
=56zZ
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]