[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gawk] bug in gawkapi.c:sym_update_real
From: |
Andrew J. Schorr |
Subject: |
Re: [bug-gawk] bug in gawkapi.c:sym_update_real |
Date: |
Tue, 18 Dec 2012 12:02:41 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi,
On Tue, Dec 18, 2012 at 11:14:47AM -0500, Assaf Gordon wrote:
> Attached are 3 patches, implementing the 'header' thing we've discussed.
>
> Patch 1: The C extension (dynvar)
> Patch 2: The AWK library code (header.awk)
> Patch 3: Andrew's fix for gawkapi
>
> Comments are welcomed,
This looks pretty good. I have a few comments/questions:
1. Should there also be a way to create constant values using sym_constant
instead of sym_update?
2. If the value argument is not provided, why are you setting the value
to numeric zero instead of undefined?
3. There are 3 cases in which your function issues a fatal error. Should these
all be fatal, or could some (or all) errors just return -1 and set ERRNO? I
don't know the right approach. In a way, fatal errors are easier, but they
give the programmer less control...
Regards,
Andy
- Re: [bug-gawk] built-in variables in extensions, (continued)
- Re: [bug-gawk] built-in variables in extensions, Andrew J. Schorr, 2012/12/17
- Re: [bug-gawk] built-in variables in extensions, Assaf Gordon, 2012/12/17
- Re: [bug-gawk] parsing column title header records, Andrew J. Schorr, 2012/12/17
- Re: [bug-gawk] parsing column title header records, Assaf Gordon, 2012/12/17
- Re: [bug-gawk] bug in gawkapi.c:sym_update_real, Andrew J. Schorr, 2012/12/17
- Re: [bug-gawk] bug in gawkapi.c:sym_update_real, Assaf Gordon, 2012/12/17
- Re: [bug-gawk] bug in gawkapi.c:sym_update_real, Andrew J. Schorr, 2012/12/17
- Re: [bug-gawk] sym_constant not working properly, Andrew J. Schorr, 2012/12/17
- Re: [bug-gawk] sym_constant not working properly, Aharon Robbins, 2012/12/18
- Re: [bug-gawk] bug in gawkapi.c:sym_update_real, Assaf Gordon, 2012/12/18
- Re: [bug-gawk] bug in gawkapi.c:sym_update_real,
Andrew J. Schorr <=
- Re: [bug-gawk] bug in gawkapi.c:sym_update_real, Aharon Robbins, 2012/12/18
- Re: [bug-gawk] bug in gawkapi.c:sym_update_real, Andrew J. Schorr, 2012/12/18
- Re: [bug-gawk] bug in gawkapi.c:sym_update_real, Aharon Robbins, 2012/12/18
- Re: [bug-gawk] bug in gawkapi.c:sym_update_real, Andrew J. Schorr, 2012/12/18
- Re: [bug-gawk] built-in variables in extensions, Aharon Robbins, 2012/12/18
Re: [bug-gawk] built-in variables in extensions, Aharon Robbins, 2012/12/18
Re: [bug-gawk] built-in variables in extensions, Aharon Robbins, 2012/12/18
Re: [bug-gawk] built-in variables in extensions, Aharon Robbins, 2012/12/19