[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] Behavior of fflush with SIGPIPE on stdout [PATCH]

From: Andrew J. Schorr
Subject: Re: [bug-gawk] Behavior of fflush with SIGPIPE on stdout [PATCH]
Date: Fri, 17 Mar 2017 12:50:20 -0400
User-agent: Mutt/1.5.21 (2010-09-15)


On Fri, Mar 17, 2017 at 08:44:35AM +0200, Arnold Robbins wrote:
> Thanks for the reports and discussions. I tackled the problem with the
> patch below. I plan to commit it soon.  Andy - please review.

I generally dislike that you are calling is_non_fatal_redirect() or
is_non_fatal_std() before calling fflush. You are incurring the overhead of the
PROCINFO lookup before the fflush call fails. Why take that performance hit
until we actually encounter an I/O error?

Does the change in SIGPIPE handling have anything to do with this issue,
or is that an unrelated code cleanup?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]