Re: [bug-gawk] [PATCH 2/2] Fix plugin load failure on OS/2

[Eli Zaretskii]

> Date: Fri, 13 Oct 2017 11:10:28 +0900
> From: KO Myung-Hun <address@hidden>
> CC: address@hidden, address@hidden, Andreas Büning
>  <address@hidden>
> 
> > Thanks KO & Eli for working this out.
> > 
> > Eli Zaretskii <address@hidden> wrote:
> > 
> >> Thanks.  Let's see if there are objections, and if not, I will push it
> >> in a few days in your name.
> > 
> > Minor nit:
> > 
> >> +    char sym[strlen(name) + 1 + 1]; /* 1 for '-', 1 for NUL */
> > 
> > Should be   /* 1 for '_', 1 for NUL */
> > 
> > Please fix in both places.
> > 
> > Otherwise looks good to me.
> > 
> > I will work on the fork issue Andreas mentioned.
> > 
> > Thanks!
> > 
> > Arnold
> 
> Fixed.

Thanks, pushed to the gawk-4.2-stable branch.

In the future, please also provide ChangeLog entries for your changes.