[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] Function argument corruption in 4.2.0

From: Andrew J. Schorr
Subject: Re: [bug-gawk] Function argument corruption in 4.2.0
Date: Sun, 12 Nov 2017 22:13:06 -0500
User-agent: Mutt/1.5.21 (2010-09-15)


On Sun, Nov 12, 2017 at 04:04:41PM -0800, Eric Pruitt wrote:
> Oh wait, this is interesting: the bisect reported a different commit
> this time around that actually looks like it's related:
>     commit f8424b236fabb881cc977b9e8e2e7c8debf56da0
>     Author: Andrew J. Schorr <address@hidden>
>     Date:   Wed Jul 6 18:11:10 2016 -0400
>         Now that all fields are NUL-terminated, we can eliminate $n copying
>         in the interpreter.

Interesting. This comment is misleading, since a bunch of patches from the 6th
were later reverted on the 8th, and the fields are in fact not NUL-terminated
in the current code. We tried to audit everything to make sure that it is OK to
pass around non-NUL-terminated strings.  Maybe we missed a spot, so that yes,
this commit could trigger the problem. Reverting this commit is not a
good option, so we need to chase down what's going wrong downstream.

> Sure -- I've had complaints where people would prefer no bug report over a bug
> report without a **simple** test case and / or a patch, so I was reticent to
> dump a bunch of attachments in the first message. These attachments are:
> - mdlint: The AwK script in question.
> - Makefile: This has a few rules to make testing my script easier.
> - test.in: This is the file that's fed to mdlint for testing.
> - test.out: This is the expected output of mdlint.
> - cmark-output.xml: This is the XML generated by the cmark binary. If
>   you don't have / want to build cmark, you'll need to change the
>   command on line 1272 to "cat cmark-output.xml".

Thanks for sharing this. Of course a simple bug report is easier to work with,
but sometimes that's not on the menu. :-) I am crazy busy, but will try to find
some time to investigate.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]