gdb 5.0.92 compile fails for mips-wrs-vxworks

[Craig Metz]

  Host platform is i686-pc-linux. When compiling remote-vx, you get:

In file included from remote-vx.c:53:
vx-share/ptrace.h:44:8: warning: extra tokens at end of #endif directive
In file included from remote-vx.c:55:
vx-share/xdr_ld.h:45:9: warning: extra tokens at end of #endif directive
In file included from remote-vx.c:56:
vx-share/xdr_rdb.h:137:9: warning: extra tokens at end of #endif directive
In file included from remote-vx.c:57:
vx-share/dbgRpcLib.h:32:8: warning: extra tokens at end of #endif directive
remote-vx.c: In function `net_load':
remote-vx.c:136: warning: passing arg 3 of pointer to function from 
incompatible pointer type
remote-vx.c:136: warning: passing arg 4 of pointer to function from 
incompatible pointer type
remote-vx.c:136: warning: passing arg 5 of pointer to function from 
incompatible pointer type
remote-vx.c:136: warning: passing arg 6 of pointer to function from 
incompatible pointer type
remote-vx.c: In function `net_wait':
remote-vx.c:341: `PIDGET' undeclared (first use in this function)
remote-vx.c:341: (Each undeclared identifier is reported only once
remote-vx.c:341: for each function it appears in.)
remote-vx.c:341: parse error before "inferior_ptid"
remote-vx.c: In function `vx_run_files_info':
remote-vx.c:568: warning: implicit declaration of function `local_hex_string'
remote-vx.c:568: warning: format argument is not a pointer (arg 3)
remote-vx.c: In function `net_connect':
remote-vx.c:877: warning: implicit declaration of function `inet_addr'
remote-vx.c: In function `vx_wait':
remote-vx.c:983: warning: format argument is not a pointer (arg 4)
remote-vx.c:936: warning: `pid' might be used uninitialized in this function
remote-vx.c: In function `vx_open':
remote-vx.c:1120: warning: passing arg 1 of `catch_errors' from incompatible 
pointer type
remote-vx.c:1129: warning: passing arg 2 of pointer to function from 
incompatible pointer type
remote-vx.c:1129: warning: passing arg 3 of pointer to function from 
incompatible pointer type
remote-vx.c:1159: warning: passing arg 1 of `catch_errors' from incompatible 
pointer type
remote-vx.c:1165: warning: passing arg 2 of pointer to function from 
incompatible pointer type
remote-vx.c:1165: warning: passing arg 3 of pointer to function from 
incompatible pointer type
remote-vx.c: In function `vx_attach':
remote-vx.c:1194: warning: format argument is not a pointer (arg 2)
remote-vx.c: In function `vx_detach':
remote-vx.c:1242: warning: format argument is not a pointer (arg 2)
remote-vx.c: In function `vx_kill':
remote-vx.c:1273: warning: format argument is not a pointer (arg 2)
remote-vx.c: In function `init_vx_ops':
remote-vx.c:1355: warning: assignment from incompatible pointer type
remote-vx.c: In function `init_vx_run_ops':
remote-vx.c:1380: warning: assignment from incompatible pointer type
remote-vx.c:1381: warning: assignment from incompatible pointer type
remote-vx.c:1382: warning: assignment from incompatible pointer type

  The quick-fix appears to be to change remote-vx.c line 341:

  pid = PIDGET inferior_ptid);

  to:

  pid = PIDGET(inferior_ptid);

  i.e., this is just a typo, and it's easily fixed.

  There are *a lot* of warnings in this target's compile, and there should be
none. Someone with more GDB internal knowledge than I have really should try
compiling for this target and looking over the warnings. I'd be surprised if
there weren't at least a few bugs to be found.

                                                                        -Craig