Re: [bug-gettext] [PATCH] gettext-runtime: use @SHELL@ for the SHELL variable definition

[Mike Rosset]

Thanks for this, I created a patch for awhile back for
https://github.com/str1ngs/clutter-android.

The problem only occurs under certain corner cases. For example if
/bin/sh is not symlinked to bash in the case of ubuntu where they use
dash and only while boot strapping autoconf submodules. But due to the
complexity of autotools I was worried it might break something else.

While I was bisecting from my impression Makfile.in was hard copied
over and this issue has gone unnoticed since that time and more then
likely this patch is fine. Either way +1 if this can get applied.

On Tue, May 28, 2013 at 5:07 AM, Thomas Petazzoni
<address@hidden> wrote:
> The gettext-runtime/Makefile.in uses an hardcoded SHELL = /bin/sh
> variable. This causes problems at build time, because libtool is then
> called with the 'sh' shell, which does not support the += construct
> that the libtool script is using.
>
> Instead, this Makefile.in should be definining SHELL = @SHELL@, just
> like all other Makefile.in of gettext.
>
> Signed-off-by: Thomas Petazzoni <address@hidden>
> ---
>  gettext-runtime/intl/Makefile.in |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gettext-runtime/intl/Makefile.in 
> b/gettext-runtime/intl/Makefile.in
> index 0f3f46c..7151d39 100644
> --- a/gettext-runtime/intl/Makefile.in
> +++ b/gettext-runtime/intl/Makefile.in
> @@ -17,7 +17,7 @@
>  PACKAGE = @PACKAGE@
>  VERSION = @VERSION@
>
> -SHELL = /bin/sh
> +SHELL = @SHELL@
>
>  srcdir = @srcdir@
>  top_srcdir = @top_srcdir@
> --
> 1.7.9.5
>
>