Re: [bug-gettext] [PATCH] Add a test wrapper to avoid temp file name collision.

[Stefano Lattarini]

Hi Daiki.

On 05/30/2013 08:53 AM, Daiki Ueno wrote:
> Daiki Ueno <address@hidden> writes:
> 
>> On the other hand, by hooking strace to each test, it turned out that
>> the file name collisions are only 34 (listed below).
>>
In the long term, I think it would be nice to ensure each test runs in
its own subdirectory, not to have to worry about possible conflicts in
the names of temporary files (and the headache-causing racy failures
usually associated with that).  Packages like Automake and Coreutils
have been running each test in its own subdirectory for a long time,
and have lived very happily ever after.

>> So maybe good to fix the tests directly.
>
In the meantime, though, I agree this is an acceptable band-aid.  My
proposed change would likely require and audit and partial rethinking
of the whole testsuite, and that could be very time-consuming.


> I did this and pushed the 'parallel-tests' patch on top of it.  I've
> confirmed that it works with "make -j4 check" so far, but more testing
> would be appreciated.
> 
> Regards,
>

I tried, but unfortunately encountered this build failure during
the ./autogen.sh run from a clean checkout:

  ...
  libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" 
\
  -DEXEEXT=\"\" -I. -I.. -I../intl -I../intl -I.. -I.. -DDEPENDS_ON_LIBICONV=1 \
  -DDEPENDS_ON_LIBINTL=1 -DLIBXML_STATIC -I./libcroco -g -O2 -c 
libxml/threads.c \
  -fPIC -DPIC -o libxml/.libs/libxml_rpl_la-threads.o
  libxml/threads.c: In function 'xmlGetGlobalState':
  libxml/threads.c:533:33: error: 'xmlOnceInit' undeclared (first use in this 
function)
  libxml/threads.c:533:33: note: each undeclared identifier is reported only 
once for each function it appears in
  libxml/threads.c:537:9: warning: implicit declaration of function 
'xmlNewGlobalState' [-Wimplicit-function-declaration]
  libxml/threads.c:537:31: warning: initialization makes pointer from integer 
without a cast [enabled by default]
  libxml/threads.c: In function 'xmlIsMainThread':
  libxml/threads.c:649:33: error: 'xmlOnceInit' undeclared (first use in this 
function)
  make[1]: *** [libxml/libxml_rpl_la-threads.lo] Error 1
  make[1]: Leaving directory 
`/storage/home/stefano/src/gnu/gettext/gettext-tools/gnulib-lib'
  make: *** [all] Error 2

Can you reproduce?  If not, let me know whether you need more details.

Regards,
  Stefano