Re: [bug-gettext] xgettext segmentation fault javascript

[Johan Liljegren]

Hi

2014-10-25 10:23 GMT+02:00 Daiki Ueno <address@hidden>:

Hello,

Andreas Stricker <address@hidden> writes:

> I can reproduce this with Debian testing default xgettext. But it
> doesn't look _javascript_ specific. e.g. if I create two identical
> files 1.c and 2.c with the content:
>
> int a() { ngettext("bla", 1); }
>
> And call it like this:
>
> xgettext --keyword=ngettext:1,1 -o - 1.c 2.c
>
> *** Error in `xgettext': double free or corruption (fasttop):
> 0x0000000001428470 ***
>
> I'm not sure if this keyword argument is valid, but at least
> it should not die like this.

Thanks for the report and investigation.  It seems to be a long-standing
bug since 0.18, after this change:
http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=6aa7b7ed

I'm not sure if this change is intentional nor what's the best way to
handle this use-case, but here is a patch to recover the original
behavior.



Regards,
--
Daiki Ueno

Thanks for the patch!

xgettext doesn't crash but the ngettext call is no longer recognized unless using the standard form ngettext(singular, plural, count). Is this what you refer to as the original behavior?

I really do like the ability to change this via --keyword since it lets us avoid having to write the key twice.

Although my coding in C is limited at best, if there is any way I can help please let me know.

Regards, Johan