[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 2.2.4, gsed != sed
From: |
Andreas Jaeger |
Subject: |
Re: 2.2.4, gsed != sed |
Date: |
Fri, 28 Dec 2001 20:24:36 +0100 |
User-agent: |
Gnus/5.090004 (Oort Gnus v0.04) XEmacs/21.4 (Artificial Intelligence, i386-suse-linux) |
Toomas Rosin <address@hidden> writes:
> Hello!
>
> If gsed != sed, then build fails in the "intl" subdirectory (duplicate
> label 'b' in po2test.sed:53). `configure' checks for gsed, but the
> result is not used anywhere.
>
> Fix (against the 2.2.4 release):
>
> --- config.make.in.~1~ Mon Jul 23 19:53:35 2001
> +++ config.make.in Sat Dec 22 22:37:04 2001
> @@ -83,6 +83,7 @@
> MIG = @MIG@
> PWD_P = @PWD_P@
> BISON = @BISON@
> +SED = @SED@
>
> # Installation tools.
> INSTALL = @INSTALL@
> --- intl/Makefile.~1~ Mon Dec 17 02:56:49 2001
> +++ intl/Makefile Mon Dec 17 02:59:13 2001
> @@ -77,7 +77,7 @@
>
> $(objpfx)msgs.h: po2test.sed ../po/de.po
> $(make-target-directory)
> - sed -f $^ > $@
> + $(SED) -f $^ > $@
>
> CFLAGS-tst-gettext.c = -DTESTSTRS_H=\"$(objpfx)msgs.h\"
> CFLAGS-tst-gettext2.c = -DOBJPFX=\"$(objpfx)\"
There're more places that could need SED both in Makefiles and shell scripts.
The patch is fine and I'd like to commit it together with a replace of
sed with $(SED) in all Makefiles. Uli, what do you think?
I'm not sure what to do with the shell scripts. Should we ignore
those for now?
Andreas
--
Andreas Jaeger
SuSE Labs address@hidden
private address@hidden
http://www.suse.de/~aj
- 2.2.4, gsed != sed, Toomas Rosin, 2001/12/22
- Re: 2.2.4, gsed != sed,
Andreas Jaeger <=
- Re: 2.2.4, gsed != sed, Ulrich Drepper, 2001/12/28
- Re: 2.2.4, gsed != sed, Ulrich Drepper, 2001/12/29
- Re: 2.2.4, gsed != sed, Andreas Jaeger, 2001/12/29
- Re: 2.2.4, gsed != sed, Ulrich Drepper, 2001/12/29