bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add option --file to gtags


From: Shigio Yamaguchi
Subject: Re: [PATCH] add option --file to gtags
Date: Mon, 01 Aug 2005 00:50:18 +0900

> This is revised version. 
> 
>  gtags/gtags.c       |   33 +++-
>  gtags/manual.in     |    4
>  libutil/Makefile.am |    2
>  libutil/filelist.c  |  418 +++++++++++++++++++++++++++++++++++++++++++++++++
+++
>  libutil/filelist.h  |   27 +++
>  libutil/global.h    |    1
>  6 files changed, 480 insertions(+), 5 deletions(-)

It seems that filelist.c and find.c have large amount of common code.
How about using the same find_xxx() interface for reading from file list?
In fact, in the aspect on the call side, it should be seeing in the same.

For example,
[open]
        find_open(flag) flag == USE_FIND or USE_FILELIST
    or
        find_open()
        find_open_filelist()
[read]
        find_read()
[close]
        find_close()

By the way, I cannot connect the Internet for about one week.
Thank you for your job!
--
Shigio YAMAGUCHI <address@hidden> - Tama Communications Corporation
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]