bug-gnats
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug in gnats-change-database in gnats.el


From: george stewart
Subject: bug in gnats-change-database in gnats.el
Date: 19 Feb 2003 11:22:41 -0500
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2

Here's patch for gnats.el.  Without this, you get "Wrong type argument".

Index: gnats.el
===================================================================
RCS file: /cvsroot/gnats/gnats/gnats/gnats.el,v
retrieving revision 1.33
diff -u -p -r1.33 gnats.el
--- gnats.el    4 Aug 2002 17:16:29 -0000       1.33
+++ gnats.el    19 Feb 2003 15:54:56 -0000
@@ -1626,7 +1626,7 @@ QUERY is a string representing a query i
         (string-to-number
          (read-from-minibuffer "Port: " (if gnats-port
                                             (format "%d" gnats-port)
-                                          1529)))
+                                          "1529")))
         (read-from-minibuffer "User: " (or gnats-user (user-login-name)))))
   (setq gnats-database database
        gnats-server host


Also, I believe that gnats-get-addr-info needs some fixing.  

Here query-args is built with:

           (query-args (append (when database (list "--database" database))
                               (when database (list "--host" server))
                               (when database (list "--port" port))
                               (when database (list "--user" user))
                               (when database (list "--passwd" password))))

Shouldn't this be:
           (query-args (append (when (and database (not (equal database ""))) 
                                          (list "--database" database))
                               (when (and server (not (equal server "")))
                                          (list "--host" server))
                               (when (and port (not (equal port "")))
                                          (list "--port" port))
                               (when (and user (not (equal user "")))
                                 (list "--user" user))
                               (when (and password (not (equal password ""))) 
                                 (list "--passwd" password))))


In this case, reproducing isn't easy.  Somehow I managed to get nil in one of 
these values, and that will result in failure of call-process.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]