[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 21.1: mh-e folder mode displayed incorrectly
From: |
Peter S Galbraith |
Subject: |
Re: 21.1: mh-e folder mode displayed incorrectly |
Date: |
Fri, 26 Oct 2001 10:25:20 -0400 |
Gerd Moellmann wrote:
> Peter S Galbraith <GalbraithP@dfo-mpo.gc.ca> writes:
>
> > For example, when mh-summary-height is set to 6 or 8 or 10, the
> > recenter puts the cursor one line too high (whereas pre-patched
> > emacs21.1 would put it one line too low). So your patches
> > overcompensates a little. Will my font size affect the result?
> > Or was that accounted for? (I'm using 9x15)
>
> The problem is that recenter in 21 really has to work pixel-based
> (consider variable-height lines), whereas it was line-based in 20. To
> get the same results in 21 compared to 20 is not really easy because
> of this difference.
Right. This is why I was asking if I should try using various
font sizes or not.
> Could you please try, in the patch I sent you to increase/decrease
> the right side of the comparison in
>
> /* This is heuristic. In a window that's 3 lines high, with
> a line height of 13 pixels each, recentering with point
> on the bottom line will try to move -39/2 = 19 pixels
> backward. Try to avoid moving into the first line. */
> && it->current_y - target_y > line_height / 2
>
> and see what a good value is?
Either of these worked well in font 9x15 and 8x13:
&& it->current_y - target_y > line_height
&& it->current_y - target_y > line_height / 3 * 2
Thanks!
Peter
- Re: 21.1: mh-e folder mode displayed incorrectly, (continued)
- Re: 21.1: mh-e folder mode displayed incorrectly, Peter S Galbraith, 2001/10/23
- Re: 21.1: mh-e folder mode displayed incorrectly, Gerd Moellmann, 2001/10/23
- Re: 21.1: mh-e folder mode displayed incorrectly, Peter S Galbraith, 2001/10/23
- Re: 21.1: mh-e folder mode displayed incorrectly, Bill Wohler, 2001/10/23
- Re: 21.1: mh-e folder mode displayed incorrectly, Gerd Moellmann, 2001/10/25
- Re: 21.1: mh-e folder mode displayed incorrectly, Kevin Rodgers, 2001/10/24
- Re: 21.1: mh-e folder mode displayed incorrectly, Peter S Galbraith, 2001/10/24
- Re: 21.1: mh-e folder mode displayed incorrectly, Gerd Moellmann, 2001/10/25
- Re: 21.1: mh-e folder mode displayed incorrectly, Peter S Galbraith, 2001/10/25
- Re: 21.1: mh-e folder mode displayed incorrectly, Gerd Moellmann, 2001/10/26
- Re: 21.1: mh-e folder mode displayed incorrectly,
Peter S Galbraith <=
- Re: 21.1: mh-e folder mode displayed incorrectly, Gerd Moellmann, 2001/10/27
- Re: 21.1: mh-e folder mode displayed incorrectly, Andreas Schwab, 2001/10/24