Re: RMAIL, summary/message focus switching with `h' button

[Thien-Thi Nguyen]

Alexander Pohoyda <alexander.pohoyda@gmx.net> writes:

   +  (let (was-in-summary)
   +    (if (eq major-mode 'rmail-summary-mode)
   +       (setq was-in-summary t))
   +    (rmail-new-summary "All" '(rmail-summary) nil)
   +    ;; Swap the focus.
   +    (if was-in-summary
   +       (other-window 1))))

a minor style nit, that does not address the suitability of the patch:

you can tighten the binding construct to something like:

   (let ((was-in-summary (eq major-mode 'rmail-summary-mode)))
      ...)

this is because `eq' is a predicate and `was-in-summary' is used as a
predicate var.  also, in the combined form `setq' is unnecessary.

thi